Repository navigation
fix(deps): raise optional-extra floors past known-vulnerable releases - #314
Merged
Merged
Conversation
Three optional extras declared lower bounds that still admit releases with published advisories, so a fresh `pip install tina4-python[push]` (or [mysql] / [mongo] / [all-db] / [test]) could resolve a vulnerable version. That is what the Snyk manifest scan has been flagging on every pyproject.toml change (it failed on both the 3.13.162 and 3.13.163 release PRs). The locked versions were never affected. - cryptography >=42.0 -> >=50.0.0 (42.0 carries 15 advisories; 49.x still 2: GHSA-g6cj-pr64-35w5 / PYSEC-2026-3552, fixed in 50.0.0) - mysql-connector-python >=9.0 -> >=9.1.0 (GHSA-hgjp-83m4-h4fj, PYSEC-2026-1685) - pymongo >=4.18.2 -> >=4.18.3 (GHSA-98qm-wvgf-w4cf) Each new floor has 0 known advisories in OSV. uv.lock is regenerated without --upgrade: every pinned version is unchanged (the locked cryptography 50.0.1, mysql-connector-python 9.6.0 and pymongo 4.18.3 already sat above the new floors); only the stale tina4-python self-entry moves 3.13.157 -> 3.13.163. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Tina4 <82961293+tina4stack@users.noreply.github.com> Signed-off-by: Andre van Zuydam <andrevanzuydam@gmail.com>
Collaborator
Author
|
Follow-up: Snyk still fails on this PR, so these floors were not (all of) what Snyk flags. Merged anyway, because they genuinely allowed releases with published advisories, and the new floors have 0 in OSV. What's left is visible only in Snyk's own data. Every pinned package in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why Snyk keeps failing.
security/snykhas failed on every PR that touchespyproject.toml, including the 3.13.162 and 3.13.163 release PRs. tina4-python has no runtime dependencies, and all 61 packages pinned inuv.lockhave 0 known advisories (checked against OSV). Snyk scans the manifest, though, and three optional extras declare floors that still allow vulnerable releases. So a freshpip install tina4-python[push](or[mysql],[mongo],[all-db],[test]) could resolve one.cryptography>=42.0>=50.0.0mysql-connector-python>=9.0>=9.1.0pymongo>=4.18.2>=4.18.3uv.lockis regenerated without--upgrade, so every pinned version is unchanged. The locked cryptography 50.0.1, mysql-connector-python 9.6.0 and pymongo 4.18.3 were already above the new floors. The only lock change is the stale tina4-python self-entry, 3.13.157 → 3.13.163.Proof: this PR changes
pyproject.toml, so Snyk scans it. A pass here confirms these floors were the finding. PHP, Ruby and Node passed Snyk on their 3.13.163 manifest changes, so this is Python-only.🤖 Generated with Claude Code